4 replies to this topic

[Rochet2]

I tested my "skills" on C++ by creating a teleporter for trinity.
After 2 days I now have this.

I know there are somethings that could be done better etc. so I would like if someone could point things like that to me.

Here is the script:
http://pastebin.com/EaVzWRUJ

I have changed it a bit after posting it there, but those were just minor tunes, like the string array being 2 columns long, not 100.

[Thetruecrow]

Very nice.

[Rochet2]

With a suggestion from Foereaper and a little comment from trinitycore
I made a couple updates.

Updated script with the above, loop breaking when found all the options for the menu (no useless looping after),
removed comments, added return false, deleted some unnecessary bracets and some other.

Someone on Trinitycore forums said that using case would be better and faster, but I dont really know where to use it.
Almost all my ifs are having more than one .. "argument" .. whats it called..

[arcemu]

Quote

I have changed it a bit after posting it there, but those were just minor tunes, like the string array being 2 columns long, not 100.

You call allocating 50x more than you actually need a "minor tune"?
Imagine if 1 allocation costed 1 billion dollar....

[Rochet2]

Hehe, well..
It was just a test value when I was creating it.
I do call changing one value minor tuning, as the effect to the result did not make a difference, but it does in the performance and / or amount of space consumed.

It did not revamp any part of the script.